You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've worked around it in our packaging by extending those two tests with the gcc_x86 fixture, and I would be happy to submit that change as an MR if it is palatable. Technically, -march=native would work on at least aarch64 as well.
The text was updated successfully, but these errors were encountered:
Thanks for the report! I would rather add some arch specific expectations than exclude those tests altogether on non-x86. For -mtune, perhaps even do something like this
--- a/test/t/test_gcc.py+++ b/test/t/test_gcc.py@@ -60,5 +60,8 @@ class TestGcc:
assert "native" in completion
@pytest.mark.complete("gcc -mtune=")
- def test_mtune_generic(self, completion, gcc_with_completion):- assert "generic" in completion+ def test_mtune(self, completion, gcc_with_completion):+ # generic: x86, some others+ # power*: ppc+ assert "generic" in completion or \+ any(x.startswith("power") for x in completion)
(Aside, when we sometime get the macOS tests to usable state in GitHub CI, we could get a bit of coverage on these.)
Describe the bug
The
test_march_native
andtest_mtune_generic
tests fail when run on my 64-bit PowerPC workstation.To reproduce
-march
in GCC (or supportgeneric
for-mtune
).make check
).Expected behavior
Passing tests.
Versions (please complete the following information)
echo "$BASH_VERSION"
: 5.1.16(1)-release(IFS=.; echo "${BASH_COMPLETION_VERSINFO[*]}")
: affects git HEAD, but testing with 2.13.0.Additional context
GCC doesn't use
-march
for every ISA, and-mtune=generic
isn't available on every arch either.Debug trace
I've worked around it in our packaging by extending those two tests with the
gcc_x86
fixture, and I would be happy to submit that change as an MR if it is palatable. Technically,-march=native
would work on at least aarch64 as well.The text was updated successfully, but these errors were encountered: