[Regression] make autocompletion skips install

[tsdgeos]

Describe the bug

To reproduce

0. rename the Makefile.txt to Makefile (github won't let me upload it with it's correct name) and put it in a folder
1. cd to 'directory_that_contains_attached_Makefile'
2. Type 'make inst' and press the TAB key
3. See that it autocompletes to make install/

Expected behavior

It should autocomplete to make install like it used to (given that there is an install target in the Makefile)

Versions (please complete the following information)

• Operating system name/distribution and version: ArchLinux
• bash version, echo "$BASH_VERSION": 5.2.26(1)-release
• bash-completion version, (IFS=.; echo "${BASH_COMPLETION_VERSINFO[*]}"): 2.14.0

Additional context

This used to work with bash completion 2.11

[akinomyoga]

0. rename the Makefile.txt

Minimal reproducer:

install:
.PHONY : install
install/fast:
.PHONY : install/fast
install/local:
.PHONY : install/local

[akinomyoga]

The current implementation of the make completion assumes install to be a directory name when other targets like install/fast and install/local exist. Then, it considers that the main targets are install/fast and install/local and removes the target install assuming it is a secondary target just to prepare a directory for the main targets.

Maybe we can preserve the phony targets as is, but in the current implementation, the stages of generating targets and filtering the paths are separated. The latter stage doesn't know which ones were generated as phony targets.

[tsdgeos]

The current implementation of the make completion assumes install to be a directory name when other targets like install/fast and install/local exist.

Please don't do that :)