Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle make targets with / correctly #858

Closed
3 tasks done
ncfavier opened this issue Dec 17, 2022 · 3 comments
Closed
3 tasks done

Handle make targets with / correctly #858

ncfavier opened this issue Dec 17, 2022 · 3 comments

Comments

@ncfavier
Copy link

ncfavier commented Dec 17, 2022

Describe the bug

When completing make foo/<Tab>, a target named foo/bar gets listed as just bar, and completing it removes the foo/ prefix.

Also, completing foo<Tab> inserts a slash and a space. It should not insert a space, just like filename completion works.

To reproduce

  1. git clone --depth=1 https://github.com/NixOS/nix
  2. cd nix
  3. make tests/<Tab>

Versions (please complete the following information)

  • Operating system name/distribution and version: NixOS unstable
  • bash version, echo "$BASH_VERSION": 5.1.16(1)-release
  • bash-completion version, (IFS=.; echo "${BASH_COMPLETION_VERSINFO[*]}"): 2.11
@akinomyoga
Copy link
Collaborator

Thanks for the report! I believe this is a duplicate of #544. A fix is proposed at #546 but is blocked by an issue related to the test framework. Maybe I should take a look at it again and decide to revert the feature introduced in commit 39f00f9 that attempts to show the completion list in a compact form.

@ncfavier
Copy link
Author

Thanks, feel free to close.

@akinomyoga
Copy link
Collaborator

Thank you for your reply! If you have further comments later, you can post them in #544. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants