Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub suggested changes commit message doesn't get DCO #8

Closed
scottrigby opened this issue Aug 11, 2020 · 0 comments · Fixed by #9
Closed

GitHub suggested changes commit message doesn't get DCO #8

scottrigby opened this issue Aug 11, 2020 · 0 comments · Fixed by #9
Labels
enhancement New feature or request

Comments

@scottrigby
Copy link
Owner

scottrigby commented Aug 11, 2020

Re https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request

When a PR author is prompted to "commit suggestion" the commit message textarea should be populated with the configured DCO signoff.

I see this happened in helm/chart-releaser#72 and was brought to my attention by @unguiculus - thanks!

I noticed when resolving a merge conflict GitHub UI gives no text box, but it seems DCO bot ignores merge commits anyway so, that's probably OK?

If anyone notices other places we can target please lmk 💖

@scottrigby scottrigby changed the title GitHub suggestions commit message Add DCO to GitHub suggested changes commit message Aug 12, 2020
@scottrigby scottrigby changed the title Add DCO to GitHub suggested changes commit message GitHub suggested changes commit message doesn't get DCO Aug 12, 2020
@scottrigby scottrigby added the enhancement New feature or request label Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant