New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs: uploaded files #497

Open

WinterSilence opened this issue Feb 19, 2021 · 0 comments

WinterSilence commented Feb 19, 2021

grocery-crud/application/libraries/Grocery_CRUD.php

Line 1300 in fcdde04

$delete_result = $this->basic_model->db_delete($primary_key_value);

files not removes on delete record, fix:

if ($this->upload_fields && $primary_key_value) {
    $row = $this->basic_model->get_edit_values($primary_key_value);
    if ($row) {
        foreach ($this->upload_fields as  $field_name => $field_info) {
            $state_info->file_name = $row->{$field_name};
            $this->delete_file($state_info);
        }
    }
}

need fix related values.

grocery-crud/application/models/Grocery_crud_model.php

Line 511 in fcdde04

function db_file_delete($field_name, $filename)

ignore default value of field,
Files of unstored/unsaved records uploads in storage - if you delete that files, they not removes in filesystem
File manager in visual editors don't auth user - it's stupid backdoor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment