Quick fix to get new Scala collections compatibility in test. #228
Conversation
|
The deprecated |
| compiler.assertNMeasuredStatements(11) | ||
| // 2 statements for the two applies in Seq, one for each literal which is 6, one for the operation passed to yield. | ||
| // Depending on the collections api version, there can be additional implicit canBuildFrom statements. | ||
| compiler.assertAtLeastNStatements(9) |
There was a problem hiding this comment.
We can check the version of Scala here and expect different number of statements based on it:
val expectedStatementsCount = if (ScoverageCompiler.ShortScalaVersion < "2.13") 11 else 9
compiler.assertNMeasuredStatements(expectedStatementsCount)| @@ -33,7 +32,7 @@ class InvokerConcurrencyTest extends FunSuite with BeforeAndAfter { | |||
| Future { | |||
| Invoker.invoked(i, measurementDir.toString) | |||
| } | |||
| }(breakOut) | |||
| }.toList | |||
There was a problem hiding this comment.
Actually we don't need a list here, set would be good (val futures: Set[Future[Unit]] ...)
|
Thank you @JanBessai for your PR. |
|
Done. I've also removed some deprecated calls to prevent future breakage. |
|
Thank you Jan |
As described in #225 .