Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop-down does not close when opened and block pulled out from flyout #283

Closed
tmickel opened this issue Apr 25, 2016 · 0 comments · Fixed by #285
Closed

Drop-down does not close when opened and block pulled out from flyout #283

tmickel opened this issue Apr 25, 2016 · 0 comments · Fixed by #285
Assignees
@tmickel
Labels
bug
Milestone
May 19

Comments

@tmickel
Copy link
Contributor

tmickel commented Apr 25, 2016

We're likely missing a call to DropDownDiv.hideWithoutAnimation for this case where a new block is created from the flyout.
@tmickel tmickel self-assigned this Apr 25, 2016
@tmickel tmickel added the bug label Apr 25, 2016
@tmickel tmickel added this to the May 19 milestone Apr 25, 2016
@tmickel tmickel mentioned this issue Apr 25, 2016
Merged
thisandagain pushed a commit that referenced this issue May 17, 2016
@rachel-fenichel
Merge pull request #283 from rachel-fenichel/feature/connect_no_next
7f1081f 
Don't connect a block with no next connection if that would force a b…
picklesrus pushed a commit to picklesrus/scratch-blocks that referenced this issue Aug 4, 2017
@paulkaplan
Merge pull request scratchfoundation#283 from paulkaplan/required-pro…
dcaec8e 
…p-types

Stricter PropType validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmickel tmickel

Labels
bug
Projects
None yet
Milestone
May 19
Development

Successfully merging a pull request may close this issue.

Drop-down and field bug fixes
1 participant
@tmickel