Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RoomPosition.findClosestBy*() Doc Clarity #124

Open
Lujia-Cheng opened this issue Mar 28, 2019 · 1 comment
Open

Improve RoomPosition.findClosestBy*() Doc Clarity #124

Lujia-Cheng opened this issue Mar 28, 2019 · 1 comment
Assignees

Comments

@Lujia-Cheng
Copy link

RoomPosition.findClosestByPath(type, [opts]) will look for objects in the same room and RoomPosition.findClosestByPath(objects, [opts]) will check all objects passed in.
However, RoomPosition.findClosestByRange(objects, [opts]) will only check for objects in the same room, ignoring any objects in other rooms, which is inconsistent with the previous method.
Would you add some clarification about this in the api?

@Lujia-Cheng Lujia-Cheng changed the title Improve RoomPosition.findClosestBy*() doc clarity Improve RoomPosition.findClosestBy*() Doc Clarity Mar 28, 2019
@o4kapuk
Copy link
Contributor

o4kapuk commented Dec 19, 2019

Thanks, we'll look into it

@o4kapuk o4kapuk self-assigned this Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants