feat(2437): Add method to get read-only flag [2] #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.js
Outdated
| /** | ||
| * Set token correctly if is read-only SCM | ||
| * @param {Object} config | ||
| * @param {String} [token] SCM token |
There was a problem hiding this comment.
extra param declaration
index.js
Outdated
| */ | ||
| getConfig(config) { | ||
| const newConfig = config; | ||
| const readOnlyToken = Hoek.reach(this.config, 'readOnly.accessToken'); |
There was a problem hiding this comment.
can we fetch the readonly config
if (newConfig && readOnlyConfig.enabled && readOnlyConfig.accessToken) {
pritamstyz4ever
approved these changes
Jun 8, 2021
jithine
reviewed
Jun 8, 2021
index.js
Outdated
| */ | ||
| getConfig(config) { | ||
| const newConfig = config; | ||
| const readOnlyToken = Hoek.reach(this.config, 'readOnly.accessToken'); |
There was a problem hiding this comment.
config already contains a username & commentUserToken. Is this newly added readOnly access token end up being same as commentUserToken ? Should we have just one token ?
There was a problem hiding this comment.
So here are my thoughts about that:
- ideally it'd be nice to have just one token but the
commentUserTokenis supposed to be strictly used for PR comments - if we want to overload it, I can change this; might cause breaking changes?
- also having a separate username is nice so that it's clear that everything in that section is for readOnly purpose, like this:
scms:
gitlab:
username: username
commentUserToken: commentToken
readOnly:
enabled: true
username: readOnlyUsername
accessToken: readOnlyToken
If you want just one of everything, could have something like this:
scms:
gitlab:
username: username
commentUserToken: token
readOnlyEnabled: true
| @@ -4,6 +4,11 @@ | |||
| const assert = require('chai').assert; | |||
| const token = 'token'; | |||
| const testParseHook = require('./data/parseHookOutput.json'); | |||
| const readOnlyConfig = { | |||
| enabled: true, | |||
| username: 'headlessbot', | |||
There was a problem hiding this comment.
in practice will this user end up same as "sd-buildbot" ? If so should we reuse the user refined in scm config section
jithine
approved these changes
Jun 9, 2021
jithine
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need to get data from the SCM config: read-only flag, scmContext.
Objective
This PR:
getReadOnlyInfo()method to return read-only SCM configgetConfig()method to inject read-only token if read-only enabledgetScmContext()method to getscmContextbased onhostnamegetWebhooksEventsMapping()References
Related to screwdriver-cd/screwdriver#2437
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.