Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: semantic release by removing verifyConditions #91

Merged
merged 3 commits into from
Jan 3, 2022
Merged

Conversation

tkyi
Copy link
Member

@tkyi tkyi commented Jan 3, 2022

Context

getChangedFiles test is failing after new data-schema changes (screwdriver-cd/data-schema#471).
Also semantic release will fail.

Objective

This PR fixes getChangedFiles test and verifyConditions for semantic release.

References

Related to #90

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Copy link
Member

@adong adong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks like webhookConfig is the new key to use now.

@tkyi tkyi merged commit 9dd96ff into master Jan 3, 2022
@tkyi tkyi deleted the tkyi-patch-1 branch January 3, 2022 19:37
@sd-buildbot
Copy link

🎉 This PR is included in version 7.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants