Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create basic UI of command key functionality #89

Closed
2 tasks done
andrewtavis opened this issue Sep 6, 2024 · 4 comments
Closed
2 tasks done

Create basic UI of command key functionality #89

andrewtavis opened this issue Sep 6, 2024 · 4 comments
Assignees
Labels
-priority- High priority feature New feature or request

Comments

@andrewtavis
Copy link
Member

Terms

Description

This is a quite important issue for Scribe-Android and the first major step towards Scribe functionality on the keyboard. This issue will add buttons for the commands above the keyboard, which further will be used for autosuggestions and other functions.

Specifically we need:

  • To the immediate right of the Scribe key a button for translation, followed by conjugation, followed by plural
    • See the designs on Figma with images that include the buttons as autosuggestions
  • In the base key view these buttons should be clear and just have labels
    • The labels for now can be Translate, Conjugate and Plural respectively
  • We need to then have the following states from Scribe-iOS added - see Keyboards/KeyboardsBase/InterfaceVariables.swift#L108
    • The buttons should be clear for idle
    • When the Scribe key is pressed, the state should change to selectCommand and the buttons should turn Scribe blue
    • When any of the command buttons are selected when the state is selectCommand, the state should change to their corresponding one - i.e. press Translate while the state is selectCommand should change the state to translate
    • When the state is translate, conjugate or plural, the command bar should be displayed as it is now

We can do any further functionality from here. Still lots to do on commands, but we can start from here!

Contribution

Happy to review and answer any questions or provide any guidance! 😊

@andrewtavis andrewtavis added feature New feature or request -priority- High priority labels Sep 6, 2024
@andrewtavis
Copy link
Member Author

@angrezichatterbox, this would also be one I'd think would be good for you so that you can set up the basis for the commands, and from there we can work on some other minor functionality parts :) :)

@angrezichatterbox
Copy link
Member

@angrezichatterbox, this would also be one I'd think would be good for you so that you can set up the basis for the commands, and from there we can work on some other minor functionality parts :) :)

Yes. I will be working on this issue.

@andrewtavis
Copy link
Member Author

Nice, great @angrezichatterbox :) Let me know if you have any questions!

@andrewtavis
Copy link
Member Author

Closed by #101 🚀 Really amazing to see the keyboard take this first great step, @angrezichatterbox!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-priority- High priority feature New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants