sync recent miner/ccc changes #1062
Merged
+37
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmountaintop
commented
Oct 10, 2024
•
0xmountaintop
commented
- fix: reuse timestamp for blocks failing CCC #1031
- refactor: eliminate double re-execution in AsyncChecker #1036
- fix: make reorg mode explicit #1049
- fix: avoid committing empty blocks after the deadline #1051
- fix: initialize pending block with an empty block #1052
0xmountaintop
changed the title
0xmountaintop
force-pushed
the
syncUpstream/less-state-access
branch
2 times, most recently
from
a16e490 to
d3b712c
Compare
0xmountaintop
force-pushed
the
syncUpstream/less-state-access
branch
from
d3b712c to
231b2ef
Compare
we assume that same height wont trigger multiple reorgs to be able to put an upper bound on the reorg depth. We rely on the fact that AsyncChecker executes transactions one-by-one and tells worker the safe set of transactions to include in the replacement block that wont trigger another error on the same block. If worker changes the timestamp and that causes significant changes to the execution flow of included transactions; we might have a height where multiple reorgs happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.