Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up GetStorage #412

Closed
haerdib opened this issue Jan 4, 2023 · 0 comments · Fixed by #448
Closed

Clean up GetStorage #412

haerdib opened this issue Jan 4, 2023 · 0 comments · Fixed by #448
Assignees
Labels
F7-enhancement Enhances an already existing functionality Q0-trivial

Comments

@haerdib
Copy link
Contributor

haerdib commented Jan 4, 2023

The current GetStorage ( https://github.com/scs/substrate-api-client/blob/7e5962bd2c9149f990b34aa25ad7bc7f6f92c868/src/api/rpc_api/state.rs) uses some outdated namings.
E.g.

fn get_storage_by_key_hash<V: Decode>(
&self,
key: StorageKey,
at_block: Option<Hash>,
) -> Result<Option<V>>;

does not get the storage by Key Hash but by StorageKey. That should be clarified.

Additionally, some explanatory comments would be nice. Check out Substrate's comments for reference: https://github.com/paritytech/substrate/blob/7d233c2446b5a60662400a0a4bcfb78bb3b79ff7/client/rpc-api/src/state/mod.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F7-enhancement Enhances an already existing functionality Q0-trivial
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants