Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a no-wasm compatible ExtrinsicSigner #461

Closed
haerdib opened this issue Feb 13, 2023 · 5 comments · Fixed by #511
Closed

Introduce a no-wasm compatible ExtrinsicSigner #461

haerdib opened this issue Feb 13, 2023 · 5 comments · Fixed by #511
Assignees
@haerdib
Labels
F7-enhancement Enhances an already existing functionality

Comments

@haerdib
Copy link
Contributor

haerdib commented Feb 13, 2023 •
edited
Loading

The current ExtrinsicSigner depends on a Runtime. But the node Runtime is not available in an environment where wasm is not supported.

Therefore, a No wasm compatible ExtrinsicSigner (implementing the same trait SignExtrinsic) where no Runtime type input is needed could be introduced.

If not possible in any other way, a hardcoded extrinsic_address type conversion may be used.

@clangenb Would that help your usecase?
@haerdib haerdib added the Z6-question Further information is requested label Feb 13, 2023
@haerdib haerdib mentioned this issue Apr 3, 2023
Merged
@haerdib haerdib added F7-enhancement Enhances an already existing functionality and removed Z6-question Further information is requested labels Apr 3, 2023
@haerdib haerdib self-assigned this Apr 3, 2023
@haerdib
Copy link
Contributor Author

haerdib commented Apr 3, 2023

Answering myself: yes, definitely. Necessary for signing extrinsic in the TEE.

@clangenb
Copy link
Collaborator

clangenb commented Apr 3, 2023

We can use the runtime inside the TEE. We do this already. :)

@clangenb
Copy link
Collaborator

clangenb commented Apr 3, 2023

Ah wait, this is only the sgx runtime. :P

@haerdib
Copy link
Contributor Author

haerdib commented Apr 3, 2023 •
edited
Loading

Hah. I just panicked for a short moment there. Was already double-checking 😨

@haerdib
Copy link
Contributor Author

haerdib commented Apr 3, 2023 •
edited
Loading

But anyway: For simply signing extrinsics, importing the full Runtime is not worth it. So it's useful either way

@echevrier echevrier mentioned this issue Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haerdib haerdib

Labels
F7-enhancement Enhances an already existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add StaticExtrinsicSigner struct scs/substrate-api-client
2 participants
@clangenb @haerdib