Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtrinsicSigner struct does not allow clone #504

Closed
1 of 2 tasks
haerdib opened this issue Mar 30, 2023 · 0 comments · Fixed by #541
Closed
1 of 2 tasks

ExtrinsicSigner struct does not allow clone #504

haerdib opened this issue Mar 30, 2023 · 0 comments · Fixed by #541
Assignees
Labels

Comments

@haerdib
Copy link
Contributor

haerdib commented Mar 30, 2023

I've run into the problem that the ExtrinsicSigner created in the worker does not seem to be cloneable. I haven't looked further into this yet. Therefore, I see the following TODOs for this issue:

Steps:

  • Try to reproduce by creating an unit test and clone the ExtrinsicSigner
  • Fix if possible & reproducible -> not possible because the Unlookup struct from substrate does not implement clone.

Workaround: Implementing a new ExtrinsicSigner that has a hardcoded Address type: see #511

But before investing too much time, this issue may be obsolete after finishing #406.

@haerdib haerdib added the F2-bug Something isn't working label Mar 30, 2023
@haerdib haerdib self-assigned this Mar 30, 2023
@haerdib haerdib changed the title Clone implementation of ExtrinsicSigner does not seem to work ExtrinsicSigner struct does not allow clone Mar 30, 2023
@echevrier echevrier linked a pull request Apr 19, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant