Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to jsdelivr cdn - Couldn't find the requested file /img/apple/64/64.png in emoji-datasource-apple. #424

Closed
dkptp opened this issue May 16, 2023 · 5 comments
Labels

Comments

@dkptp
Copy link

dkptp commented May 16, 2023

Tried updating again, this time immediately hitting this error. Switch to this new cdn doesn't seem to work or isn't configured correctly. Have to downgrade again.

image

@scttcper
Copy link
Owner

@dkptp
Copy link
Author

dkptp commented May 17, 2023

https://cdn.jsdelivr.net/npm/emoji-datasource-google@14.0.0/img/google/sheets-256/64.png is working for me

I don't really get your comment. Am I doing something wrong?
As you can see the working path you mention is different from the failing path that's in the component code.

@scttcper Line 10 in src/lib/picker/ngx-emoji/emoji.service.ts
https://cdn.jsdelivr.net/npm/emoji-datasource-${set}@14.0.0/img/${set}/64/${sheetSize}.png;

As you can see this doesn't follow the same structure as the path you commented.

It seems like this is a line that's used for retrieving the emoji sheets, which fails regardless of the set I use.

@Maker4You
Copy link

+1
browser console output(Error):
GET https://cdn.jsdelivr.net/npm/emoji-datasource-apple@14.0.0/img/apple/64/64.png 404

@Maker4You
Copy link

Maker4You commented May 19, 2023

Fix:
Go to -> YourProject\node_modules@ctrl\ngx-emoji-mart\fesm2022\ctrl-ngx-emoji-mart-ngx-emoji.mjs
Change line 33897 from:
const DEFAULT_BACKGROUNDFN = (set, sheetSize) => https://cdn.jsdelivr.net/npm/emoji-datasource-${set}@14.0.0/img/${set}/64/${sheetSize}.png;
to:
const DEFAULT_BACKGROUNDFN = (set, sheetSize) => https://cdn.jsdelivr.net/npm/emoji-datasource-${set}@14.0.0/img/${set}/sheets-256/${sheetSize}.png;

@github-actions
Copy link

🎉 This issue has been resolved in version 9.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants