Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Declare type for DisableTimeOut configuration. #959

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

Wilt
Copy link
Contributor

@Wilt Wilt commented Nov 14, 2022

Similar like ProgressAnimationType add a DisableTimoutType since it is not a simple type. This type can then be imported and used where it is declared/required in individual configuration.

Similar like ProgressAnimationType add a DisableTimoutType since it is not a simple type.
This type can then be imported and used where it is declared/required in individual configuration.
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 55.70% // Head: 55.11% // Decreases project coverage by -0.59% ⚠️

Coverage data is based on head (89d8a48) compared to base (1a0f6b8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
- Coverage   55.70%   55.11%   -0.60%     
==========================================
  Files          19       19              
  Lines         508      508              
  Branches       88       88              
==========================================
- Hits          283      280       -3     
  Misses        216      216              
- Partials        9       12       +3     
Impacted Files Coverage Δ
src/lib/toastr/toastr-config.ts 94.73% <ø> (ø)
src/lib/toastr/toastr.service.ts 48.95% <0.00%> (-2.09%) ⬇️
src/app/home/home.component.ts 58.57% <0.00%> (-1.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scttcper scttcper changed the title Declare type for DisableTimeOut configuration. fix: Declare type for DisableTimeOut configuration. Nov 14, 2022
@scttcper scttcper merged commit 7dc1745 into scttcper:master Nov 14, 2022
@scttcper
Copy link
Owner

🎉 This PR is included in version 15.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Wilt Wilt deleted the patch-1 branch November 16, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants