Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: angular 15, add toastr-bs5-alert.scss #963

Merged
merged 5 commits into from
Nov 17, 2022
Merged

feat: angular 15, add toastr-bs5-alert.scss #963

merged 5 commits into from
Nov 17, 2022

Conversation

scttcper
Copy link
Owner

@scttcper scttcper commented Nov 17, 2022

BREAKING CHANGE: support angular 15

fixes #962
fixes #887

@scttcper scttcper changed the title feat: angular 15 feat: angular 15, add toastr-bs5-alert.scss Nov 17, 2022
@scttcper scttcper merged commit bc77677 into master Nov 17, 2022
@scttcper scttcper deleted the ng15 branch November 17, 2022 07:15
@scttcper
Copy link
Owner Author

🎉 This PR is included in version 16.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@siovene
Copy link

siovene commented Nov 17, 2022

@scttcper thanks! Something must've gone wrong with the NPM release tho.

I installed 16.0.0 and toastr-bs5-alert.scss doesn't exist.

To be sure, I removed my node_modules, did npm install, checked that node_modules/ngx-toastr/package.json mentions version 16.0.0, and toastr-bs5-alert.scss doesn't exist.

Could you have missed something?

Thank you!

@siovene
Copy link

siovene commented Nov 17, 2022

$ grep toastr package.json
    "ngx-toastr": "16.0.0",
$ grep version node_modules/ngx-toastr/package.json 
  "version": "16.0.0",
$ find node_modules/ngx-toastr -name '*.scss'
node_modules/ngx-toastr/toastr-bs4-alert.scss

@siovene
Copy link

siovene commented Nov 19, 2022

Thanks, I see now that it's fixed in 16.0.1.

Dixyx pushed a commit to Dixyx/ngx-toastr that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to angular v15 Bootstrap 5 Support
2 participants