Clean up config overrides #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
- Coverage 79.92% 79.84% -0.08%
==========================================
Files 21 22 +1
Lines 523 516 -7
Branches 70 65 -5
==========================================
- Hits 418 412 -6
Misses 57 57
+ Partials 48 47 -1
Continue to review full report at Codecov.
|
scttcper
approved these changes
Sep 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding the global and individual configs was repetitive and a bit messy. This should greatly clean it up and make it more readable. Now both the global and individual configs use the same method to override the config.