Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for increasing progress bar #196

Merged
merged 3 commits into from
Oct 6, 2017
Merged

Add support for increasing progress bar #196

merged 3 commits into from
Oct 6, 2017

Conversation

trevor-hackett
Copy link
Collaborator

This add support for the increasing progress bar requested in #192

I'm not dead set on the new config property name. Any and all feedback is welcome.

@codecov
Copy link

codecov bot commented Oct 5, 2017

Codecov Report

Merging #196 into master will decrease coverage by 0.37%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   79.45%   79.07%   -0.38%     
==========================================
  Files          22       22              
  Lines         516      521       +5     
  Branches       65       67       +2     
==========================================
+ Hits          410      412       +2     
- Misses         57       59       +2     
- Partials       49       50       +1
Impacted Files Coverage Δ
src/lib/toastr/toastr-config.ts 90.47% <ø> (ø) ⬆️
src/lib/toastr/default-config.ts 100% <100%> (ø) ⬆️
src/lib/toastr/toast-component.ts 77.21% <20%> (-4.12%) ⬇️
src/lib/toastr/toastr-service.ts 58.65% <0%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 127ae48...758cce3. Read the comment docs.

@scttcper scttcper merged commit 5273ce3 into scttcper:master Oct 6, 2017
@scttcper
Copy link
Owner

scttcper commented Oct 6, 2017

sweet 🎉

@trevor-hackett trevor-hackett deleted the increasing-progress-bar branch October 31, 2017 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants