migrate obsm varm tests, skip if known issue #201
Conversation
| ad <- reticulate::import("anndata", convert = FALSE) | ||
| da <- reticulate::import("dummy_anndata", convert = FALSE) | ||
| bi <- reticulate::import_builtins() |
There was a problem hiding this comment.
Can you give these clearer names?
There was a problem hiding this comment.
Is ad not the standard naming convention for importing anndata -- that is,
import anndata as adSimilarly, I thought it'd be funny if dummy_anndata would be imported as
import dummy_anndata as daI can change the builtins, though!
There was a problem hiding this comment.
Oh, I guess so, I hadn't thought of that. It's only obvious if you know the convention though and TBH I'm not a fan of doing it in Python either, I usually import things with the full name unless it's something super common like numpy. It's a reasonable thing to do though so fine to keep it.
| @@ -39,62 +38,78 @@ for (name in test_names) { | |||
| adata_py$write_h5ad(file_py) | |||
|
|
|||
| test_that(paste0("reading an AnnData with obs and var '", name, "' works"), { | |||
| msg <- message_if_known( | |||
| backend = "HDF5AnnData", | |||
| slot = c("obsp", "varp"), | |||
There was a problem hiding this comment.
Yes!
There was a bit of copy pasting. I'm considering merging the tests into one. WDYT?
| slot = c("obsp", "varp"), | |
| slot = c("obs", "var"), |
Co-authored-by: Luke Zappia <lazappi@users.noreply.github.com>
dummy_anndata should also be able to generate data frames in obsm / varm. See data-intuitive/dummy-anndata#11