Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes, cannot rename shapes layer. #319

Open
LucaMarconato opened this issue Sep 27, 2024 · 4 comments
Open

Sometimes, cannot rename shapes layer. #319

LucaMarconato opened this issue Sep 27, 2024 · 4 comments
Assignees

Comments

@LucaMarconato
Copy link
Member

@melonora, can you please check if you can reproduce?

  1. Run this code.
from napari_spatialdata import Interactive
from spatialdata.datasets import blobs

sdata = blobs()
Interactive(sdata)
  1. Do not press anything, just create a new Shapes layer. The default name for the new layer is Shapes.
  2. Go for renaming the layer to aaa
  3. Press return. The layers gets renamed to Shapes instead of being aaa.

CleanShot 2024-09-27 at 15 21 34

@LucaMarconato
Copy link
Member Author

Sometimes it can get renamed and the above doesn't reproduce the bug. In that case, the following should:

  1. open blobs as above
  2. add a new shapes layer and rename from Shapes to something, like aaa
  3. save the layer to disk
  4. close napari, reload the disk data into a new SpatialData object
  5. create a new layer, try renaming Shapes to bbb. It won't work.

@melonora melonora self-assigned this Oct 14, 2024
@melonora
Copy link
Collaborator

I have tried reproducing as stated, but I don't seem to be able to. @timtreis do you maybe have some time to try. Wondering if this is again a Mac specific thing.

@melonora
Copy link
Collaborator

melonora commented Oct 18, 2024

@LucaMarconato any update from your side?

@liuxiawei
Copy link

Same problem, Can not rename the layer, No warning even INFO. The Label layer and Point layer can be renamed

napari                        0.5.4
napari-console                0.1.1
napari-matplotlib             3.0.0
napari-plugin-engine          0.2.0
napari-spatialdata            0.5.4.post0
napari-svg                    0.2.0
multiscale_spatial_image      2.0.2
napari-spatialdata            0.5.4.post0
spatial_image                 1.1.0
spatialdata                   0.2.6
spatialdata-io                0.1.6
spatialdata-plot              0.2.8
xarray-spatial                0.4.0
PyQt5                         5.15.10
PyQt5-sip                     12.13.0
QtPy                          2.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants