feat: Mudata support for MultiVI #3038
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…tiVI-MuData # Conflicts: # tests/model/test_multivi.py
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3038 +/- ##
==========================================
+ Coverage 84.53% 84.58% +0.05%
==========================================
Files 178 178
Lines 15062 15100 +38
==========================================
+ Hits 12732 12772 +40
+ Misses 2330 2328 -2
|
for more information, see https://pre-commit.ci
canergen
reviewed
Nov 12, 2024
canergen
reviewed
Nov 12, 2024
canergen
reviewed
Nov 12, 2024
canergen
reviewed
Nov 12, 2024
ori-kron-wis
changed the title
for more information, see https://pre-commit.ci
canergen
reviewed
Nov 14, 2024
canergen
reviewed
Nov 14, 2024
canergen
approved these changes
Nov 14, 2024
canergen
reviewed
Nov 18, 2024
canergen
reviewed
Nov 18, 2024
canergen
reviewed
Nov 18, 2024
| protein_adata2 = synthetic_iid(n_genes=50) | ||
| mdata2 = MuData({"rna": adata2, "protein": protein_adata2}) | ||
| mdata2.obs["_indices"] = np.arange(mdata2.n_obs) | ||
| model.get_elbo(mdata2) |
There was a problem hiding this comment.
I don't get this test. We should test all functions with mdata2
canergen
reviewed
Nov 18, 2024
| mdata2 = MuData({"rna": adata2, "protein": protein_adata2}) | ||
| adata2.obs.batch = adata2.obs.batch.cat.rename_categories(["batch_1", "batch_0"]) | ||
| mdata2.obs["_indices"] = np.arange(mdata2.n_obs) | ||
| model.get_elbo(mdata2) |
There was a problem hiding this comment.
Same here all tests with mdata2
There was a problem hiding this comment.
This needs to be fixed. Call other functions with mdata2
canergen
approved these changes
Nov 18, 2024
canergen
reviewed
Nov 19, 2024
# Conflicts: # CHANGELOG.md
for more information, see https://pre-commit.ci
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added mudata support for MULTIVI + tests