From 4964b4471c3d14bfea75e532b2e7c24cbd48cd65 Mon Sep 17 00:00:00 2001 From: Piotr Dulikowski Date: Thu, 2 Feb 2023 19:24:35 +0100 Subject: [PATCH] CI/Makefile: disable `uninlined_format_args` clippy lint New version of clippy introduced the `uninlined_format_args` lint which recommends putting variable names directly into format strings, like this: let what = "world"; println!("Hello, {what}!"); // Instead of: println!("Hello, {}!", what); The problem with this feature is that rust-analyzer does not support renaming variables inside format strings yet. The lint has been downgraded to pedantic level and will most likely appear as such in the next release. This commit disables the new lint in the CI and local Makefile. We can turn it on again after this feature gets better support from rust-analyzer. --- .github/workflows/rust.yml | 2 +- Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index d7ddb05deb..4ea6de6fad 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -23,7 +23,7 @@ jobs: - name: Format check run: cargo fmt --verbose --all -- --check - name: Clippy check - run: cargo clippy --verbose --examples --tests + run: cargo clippy --verbose --examples --tests -- -Aclippy::uninlined_format_args - name: Cargo check without features run: cargo check --manifest-path "scylla/Cargo.toml" --features "" - name: Cargo check with secrecy feature diff --git a/Makefile b/Makefile index 2cdb5ba922..bc5447a183 100644 --- a/Makefile +++ b/Makefile @@ -27,7 +27,7 @@ check-without-features: .PHONY: clippy clippy: - RUSTFLAGS=-Dwarnings cargo clippy --examples --tests + RUSTFLAGS=-Dwarnings cargo clippy --examples --tests -- -Aclippy::uninlined_format_args .PHONY: test test: up wait-for-cluster