Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require better error messages (quote.py) #2

Closed
sweetatyagiaz opened this issue Apr 20, 2019 · 2 comments · Fixed by #25
Closed

Require better error messages (quote.py) #2

sweetatyagiaz opened this issue Apr 20, 2019 · 2 comments · Fixed by #25
Labels
enhancement New feature or request good first issue Good for newcomers WIP Work in progress

Comments

@sweetatyagiaz
Copy link

Hi,
I am using ur package and got error for BSE code 513715. The error is at Line number 43 in quote.py.

Kindly this this into consideration.

Your code is working fine for others BSE code.

I am attaching the image of error, what I have got.

Error
@sdabhi23
Copy link
Owner

Hey @sweetatyagiaz thanks for reporting the error! I had a look at it and as you can see on https://www.bseindia.com/stock-share-price/valley-abrasives-ltd/vallyab/513715/, it seems that the company is no longer trading on BSE and hence the prices are not available.

Still this is unexpected behavior, and I would try to improve the error handling in the next release 😄

@sdabhi23 sdabhi23 added the bug Something isn't working label May 24, 2019
@sweetatyagiaz
Copy link
Author

Thanks for the replay.

@sdabhi23 sdabhi23 changed the title Error in quote.py Require better error messages (quote.py) Jun 24, 2019
@sdabhi23 sdabhi23 added enhancement New feature or request and removed bug Something isn't working labels Jun 24, 2019
@sdabhi23 sdabhi23 added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 15, 2019
@sdabhi23 sdabhi23 added WIP Work in progress and removed help wanted Extra attention is needed labels Jun 25, 2020
@sdabhi23 sdabhi23 mentioned this issue Mar 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release v0.5.0 sdabhi23/bsedata
2 participants
@sweetatyagiaz @sdabhi23