Skip to content
This repository has been archived by the owner on Feb 3, 2018. It is now read-only.

Define behavior of solver when tags move in nasty ways #6

Open
sdboyer opened this issue Apr 5, 2016 · 3 comments
Open

Define behavior of solver when tags move in nasty ways #6

sdboyer opened this issue Apr 5, 2016 · 3 comments

Comments

@sdboyer
Copy link
Owner

sdboyer commented Apr 5, 2016

Sometimes, branches move nonlinearly (e.g. force push), and sometimes, tags get moved. It's important to define how the SourceManager handles these cases to make sure we're not missing anything.

Here is, more or less, the order of considerations:

  1. Cached repos are mirrors of their upstreams - even of bad citizen changes.
  2. If a bad citizen-type change occurs, we don't actually complain about it unless something in the solving process directly touches the problematic ref.
  3. If we run into a bad-citizen change, and it's an improper move (e.g. force push) on a branch...well, we probably won't say anything about that. It's a branch; they move.
  4. If the bad-citizen change is a tag being moved, and something was pinned to the old tag, we absolutely should push out a warning to the user strongly encouraging them to make a change, as they're in a potentially risky situation (that lock might be unfulfillable on a machine without an old cache).

Some additional safety measures can be taken - for example, setting gc.pruneExpire = never could ensure oprhaned objects aren't lost on git repositories. (I'll need to research the equivalents for hg and bzr).

@sdboyer
Copy link
Owner Author

sdboyer commented Jun 22, 2016

this actually doesn't need to be MVP, i don't think

@sdboyer sdboyer removed this from the MVP milestone Jun 22, 2016
@sdboyer
Copy link
Owner Author

sdboyer commented Oct 6, 2016

We really don't care about nonlinear branch moves, I don't think, so it's just tag movement that we have to worry about.

@sdboyer sdboyer changed the title Define behavior of solver when branches and tags move in nasty ways Define behavior of solver when tags move in nasty ways Oct 6, 2016
@fabulous-gopher
Copy link

This issue was moved to golang/dep#451

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants