Skip to content
This repository has been archived by the owner on Feb 3, 2018. It is now read-only.

Add logic to disallow import cycles #66

Open
sdboyer opened this issue Jul 19, 2016 · 1 comment
Open

Add logic to disallow import cycles #66

sdboyer opened this issue Jul 19, 2016 · 1 comment

Comments

@sdboyer
Copy link
Owner

sdboyer commented Jul 19, 2016

There's a spot just waiting to do it in the checkProject() and checkPackage() methods.

For now, it's probably fine to use an offline algorithm (e.g., Tarjan SCC) to find cycles. That gives us linear time in the number of packages and dependencies. Brief searches suggest that there's probably a sublinear incremental cycle discovery algorithm out there that we can swap in later.

@fabulous-gopher
Copy link

This issue was moved to golang/dep#439

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants