Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main database contains one invalid ICAO number #121

Closed
rickstaa opened this issue Mar 6, 2023 · 0 comments · Fixed by #207
Closed

Main database contains one invalid ICAO number #121

rickstaa opened this issue Mar 6, 2023 · 0 comments · Fixed by #207
Labels
bug Something isn't working

Comments

@rickstaa
Copy link
Collaborator

rickstaa commented Mar 6, 2023

Describe the bug

As pointed out by @dziban303, the current https://github.com/sdr-enthusiasts/plane-alert-db/blob/main/plane-alert-db.csv database contains one $ICAO that is not a valid hexadecimal:

https://github.com/sdr-enthusiasts/plane-alert-db/blob/c9f0aae3b6e8935de56de33b6cfdd38700651c1e/plane-alert-db.csv#L2006

8.40E+11,JA012G,Japan Civil Aviation Bureau,Cessna Citation CJ4,C25C,Civ,Flight Inspection,Fight Calibration,Trundle Wheel,Dogs with Jobs,https://tinyurl.com/ythr9kku

Expected behaviour

The correct ICAO value should replace this.

Screenshots / Live demo link

No response

Additional context

We can uncomment the following line if this is fixed:

# contains_valid_hexes(
# main_df
# ) # NOTE: This is commented out because there are invalid values in the database.

@rickstaa rickstaa added the bug Something isn't working label Mar 6, 2023
This was referenced Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant