Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the smol runtime #113

Open
szgupta opened this issue Jan 9, 2023 · 1 comment
Open

Support for the smol runtime #113

szgupta opened this issue Jan 9, 2023 · 1 comment

Comments

@szgupta
Copy link

szgupta commented Jan 9, 2023

Hey! I was looking to use this crate within the context of the smol runtime but realized that only async-std and tokio have builtin integrations.

I was able to follow this example to get it working with smol but was wondering what a builtin smol integration would require. Albeit not a lot of extra code to support outside of the crate, this seems like something that could live nicely in the async-tungstenite crate as an optional feature. After all, async-std uses the smol executor itself.

From a quick glance, the only async-std-specific usage in src/async-std.rs is the use of async_std::net::TcpStream. This can be written in a more std way but still async with a simple smol adapter smol::Async<std::net::TcpStream>.

If you would be open to this, I'm happy to investigate adding support.

@sdroege
Copy link
Owner

sdroege commented Jan 9, 2023

that only async-std and tokio have builtin integrations

Also GLib :)

If you would be open to this, I'm happy to investigate adding support.

Sure, go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants