From 3d10ccfc1706c45305d776b545a8f4ad0656d5a8 Mon Sep 17 00:00:00 2001 From: Ke Date: Fri, 23 Aug 2024 21:27:22 -0700 Subject: [PATCH] Make processConfigs function pure virtual (#10827) Summary: to enforce every data format implement its own processConfigs functions Pull Request resolved: https://github.com/facebookincubator/velox/pull/10827 Reviewed By: xiaoxmeng Differential Revision: D61743118 Pulled By: kewang1024 fbshipit-source-id: aa1d0b2ea12deaf5b2c2f2ee16827bd6c5a73f38 --- velox/dwio/common/Options.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/velox/dwio/common/Options.h b/velox/dwio/common/Options.h index a695e30b45b9..31a6fe0ccc91 100644 --- a/velox/dwio/common/Options.h +++ b/velox/dwio/common/Options.h @@ -622,7 +622,7 @@ struct WriterOptions { // process format-specific session and connector configs. virtual void processConfigs( const config::ConfigBase& connectorConfig, - const config::ConfigBase& session) {}; + const config::ConfigBase& session) = 0; virtual ~WriterOptions() = default; };