Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate HMA case where parent is missing num_rows column #1703

Closed
frances-h opened this issue Nov 30, 2023 · 0 comments · Fixed by #2090
Closed

Investigate HMA case where parent is missing num_rows column #1703

frances-h opened this issue Nov 30, 2023 · 0 comments · Fixed by #2090
Assignees
@gsheni
Labels
internal The issue doesn't change the API or functionality
Milestone
1.15.0

Comments

@frances-h
Copy link
Contributor

frances-h commented Nov 30, 2023 •
edited by gsheni
Loading

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • SDV version:
  • Python version:
  • Operating System:

Error Description

In the _get_num_rows_from_parent method in the hierarchical sampler, we have a check to see if the num_rows column for the child is present in the parent. The _sample_children method also implements a similar check in #1696.

What, if any, examples are there where this check fails? Can these check be safely removed?
@frances-h frances-h added bug Something isn't working new Automatic label applied to new issues labels Nov 30, 2023
@frances-h frances-h mentioned this issue Nov 30, 2023
Merged
@npatki npatki removed the new Automatic label applied to new issues label Dec 1, 2023
@npatki npatki added internal The issue doesn't change the API or functionality and removed bug Something isn't working labels Jan 29, 2024
@gsheni gsheni self-assigned this Jun 20, 2024
@gsheni gsheni mentioned this issue Jun 25, 2024
Merged
@amontanez24 amontanez24 added this to the 1.15.0 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsheni gsheni

Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
1.15.0
Development

Successfully merging a pull request may close this issue.

Remove check for num_rows column in _sample_children method of HMA sdv-dev/SDV
4 participants
@npatki @amontanez24 @gsheni @frances-h