Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INFO logs mention table name as None for single table data #1814

Closed
npatki opened this issue Feb 26, 2024 · 0 comments · Fixed by #1844
Closed

INFO logs mention table name as None for single table data #1814

npatki opened this issue Feb 26, 2024 · 0 comments · Fixed by #1844
Assignees
@lajohn4747
Labels
bug Something isn't working data:single-table Related to tabular datasets
Milestone
1.11.0

Comments

@npatki
Copy link
Contributor

npatki commented Feb 26, 2024 •
edited
Loading

Environment Details

  • SDV version: 1.10.0 (latest)
  • Python version: Any
  • Operating System: Any

Error Description

When using a single table synthesizer, the INFO logs always refer to the table as table None. This is confusing and may lead users into thinking something is wrong -- as mentioned in #1797.

In reality the synthesizer is working as expected. The table is showing as None because single table synthesizers don't have a table name argument as multi-table synthesizers do.

Example

Example of log:

2024-02-19 21:58:06 - INFO - Start training...
2024-02-19 21:58:11 - INFO - Fitting table None metadata
2024-02-19 21:58:11 - INFO - Fitting formatters for table None
2024-02-19 21:58:11 - INFO - Fitting constraints for table None

Expected Output

For single table or sequential synthesizers, do not include the word None

2024-02-19 21:58:06 - INFO - Start training...
2024-02-19 21:58:11 - INFO - Fitting table metadata
2024-02-19 21:58:11 - INFO - Fitting formatters for table
2024-02-19 21:58:11 - INFO - Fitting constraints for table
@npatki npatki added bug Something isn't working data:single-table Related to tabular datasets labels Feb 26, 2024
@npatki npatki changed the title INFO logs mention table name as None when for single table data INFO logs mention table name as None for single table data Feb 26, 2024
@lajohn4747 lajohn4747 mentioned this issue Mar 7, 2024
Merged
@frances-h frances-h added this to the 1.11.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lajohn4747 lajohn4747

Labels
bug Something isn't working data:single-table Related to tabular datasets
Projects
None yet
Milestone
1.11.0
Development

Successfully merging a pull request may close this issue.

If there is no name, do not put None in the logger info sdv-dev/SDV
3 participants
@npatki @lajohn4747 @frances-h