Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMA likelihood match should respect cardinality #1834

Closed
frances-h opened this issue Mar 5, 2024 · 0 comments · Fixed by #1864
Closed

HMA likelihood match should respect cardinality #1834

frances-h opened this issue Mar 5, 2024 · 0 comments · Fixed by #1864
Assignees
Labels
bug Something isn't working data:multi-table Related to multi-table, relational datasets
Milestone

Comments

@frances-h
Copy link
Contributor

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • SDV version:
  • Python version:
  • Operating System:

Error Description

Currently, demo datasets that have children with multiple parents do not have a DiagnosticScore of 1 for RelationshipValidity. This is most likely due to the likelihood match step, which does not take cardinality into account when assigning parent values as foreign keys.

The likelihood match step should be updated so that cardinality is respected.

Steps to reproduce

from sdv.datasets.demo import download_demo
from sdv.multi_table import HMASynthesizer
from sdmetrics.reports.multi_table import DiagnosticReport

data, metadata = download_demo('multi_table', 'Dunur_v1')
synthesizer = HMASynthesizer(metadata)
synthesizer.fit(data)
sample = synthesizer.sample()

report = DiagnosticReport()
report.generate(data, sample, metadata.to_dict(), verbose=False)
report.get_details('Relationship Validity')
@frances-h frances-h added the bug Something isn't working label Mar 5, 2024
@npatki npatki added the data:multi-table Related to multi-table, relational datasets label Mar 5, 2024
@frances-h frances-h added this to the 1.12.0 milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data:multi-table Related to multi-table, relational datasets
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants