Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch parameter order in drop_unknown_references #1944

Closed
R-Palazzo opened this issue Apr 22, 2024 · 0 comments · Fixed by #1955
Closed

Switch parameter order in drop_unknown_references #1944

R-Palazzo opened this issue Apr 22, 2024 · 0 comments · Fixed by #1955
Assignees
Labels
bug Something isn't working
Milestone

Comments

@R-Palazzo
Copy link
Contributor

Environment Details

  • SDV version: 1.12.1

Error Description

Currently, in the POC module, drop_unknow_references expects the metadata and data as the first and second inputs, while the other poc methods (simplify_schema, get_random_subset) are defined with the data as the first input and the metadata as the second input. We should switch the parameter order in drop_unknow_references to be consistent with the other methods. The expected order is:

cleaned_data = drop_unknown_references(data=original_data, metadata=my_metadata)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants