You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The DataProcessor is designed to log the name of the table it is processing. This feature is particularly useful when dealing with MultiTableSynthesizers. However, currently, the table_name attribute is not being assigned, as the argument is not passed to the BaseSingleTableSynthesizer, to which the DataProcessor instance belongs.
Steps to reproduce
fromsdv.datasets.demoimportdownload_demofromsdv.multi_tableimportHMASynthesizerimportlogging# Configure logging to see INFO level messageslogging.basicConfig(level=logging.INFO)
# Download demo datadata, metadata=download_demo('multi_table', 'fake_hotels')
# Initialize HMASynthesizer with metadatahmas=HMASynthesizer(metadata)
# Fit the synthesizer to the datahmas.fit(data)
Expected Behavior
The DataProcessor should correctly log the name of the table it is processing during synthesis, aiding in the debugging process and providing clarity on the synthesis workflow.
Multiple approaches
Enhance BaseSingleTableSynthesizer Interface:
Add an additional table_name argument to the BaseSingleTableSynthesizer constructor.
Propagate this argument to the DataProcessor instance during synthesizer initialization.
Note: This approach requires adjustments to methods like get_parameters.
The text was updated successfully, but these errors were encountered:
pvk-developer
added
bug
Something isn't working
new
Automatic label applied to new issues
and removed
new
Automatic label applied to new issues
labels
Apr 26, 2024
Error Description
The
DataProcessor
is designed to log the name of the table it is processing. This feature is particularly useful when dealing withMultiTableSynthesizers
. However, currently, thetable_name
attribute is not being assigned, as the argument is not passed to theBaseSingleTableSynthesizer
, to which theDataProcessor
instance belongs.Steps to reproduce
Expected Behavior
The DataProcessor should correctly log the name of the table it is processing during synthesis, aiding in the debugging process and providing clarity on the synthesis workflow.
Multiple approaches
Enhance BaseSingleTableSynthesizer Interface:
Manual Attribute Setting in MultiTable Context:
The text was updated successfully, but these errors were encountered: