Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update columns parameter in Positive and Negative constraint #817

Closed
amontanez24 opened this issue May 24, 2022 · 0 comments · Fixed by #823
Closed

Update columns parameter in Positive and Negative constraint #817

amontanez24 opened this issue May 24, 2022 · 0 comments · Fixed by #823
Labels
feature request Request for a new feature
Milestone
0.16.0

Comments

@amontanez24
Copy link
Contributor

Problem Description

As a user, it is confusing when the same parameter name for different constraints has different purposes or meanings.

Expected behavior

  • Change the columns parameter to column_name for both the Positive and Negative constraints
  • It should only accept a string that represents a single column to constrain. Lists should no longer be supported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Request for a new feature
Projects
None yet
Milestone
0.16.0
Development

Successfully merging a pull request may close this issue.

Split GreaterThan into Inequality and ScalarInequality sdv-dev/SDV
4 participants
@npatki @amontanez24 @fealho @pvk-developer