Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message logging in metrics.smallwordness is broken #246

Closed
bockthom opened this issue Dec 16, 2023 · 0 comments
Closed

Error message logging in metrics.smallwordness is broken #246

bockthom opened this issue Dec 16, 2023 · 0 comments
Assignees
@bockthom
Labels
bug fixed/future-release fixed/has-pr
Milestone
v4.4

Comments

@bockthom
Copy link
Collaborator

Description

Logging the error message in metrics.smallworldness does not work, as logging::error does not exist. Instead, it should be logging::logerror.

coronet/util-networks-metrics.R

Line 170 in a0c3a52

logging::error(error.message)

However, this does not really matter, as the execution would be stopped in the next line via stop anyway. Thus, this bug only prevents printing the error message.

Versions

v4.3 v4.2 v4.1 v4.0
@bockthom bockthom added the bug label Dec 16, 2023
@bockthom bockthom added this to the v4.4 milestone Dec 16, 2023
bockthom added a commit to bockthom/coronet that referenced this issue Feb 8, 2024
@bockthom
Fix broken error logging in 'metrics.smallworldness'
629ca9b 
This fixes se-sic#246.

Signed-off-by: Thomas Bock <bockthom@cs.uni-saarland.de>
@bockthom bockthom mentioned this issue Feb 8, 2024
Merged
7 tasks
@bockthom bockthom self-assigned this Feb 8, 2024
bockthom added a commit to bockthom/coronet that referenced this issue Feb 9, 2024
@bockthom
Fix broken error logging in 'metrics.smallworldness'
3bd900c 
This fixes se-sic#246.

Signed-off-by: Thomas Bock <bockthom@cs.uni-saarland.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bockthom bockthom

Labels
bug fixed/future-release fixed/has-pr
Projects
None yet
Milestone
v4.4
Development

No branches or pull requests
1 participant
@bockthom