Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo lemmas from WPFix confuse the sledgehammer #827

Open
talsewell opened this issue Nov 19, 2024 · 3 comments · May be fixed by #832
Open

Demo lemmas from WPFix confuse the sledgehammer #827

talsewell opened this issue Nov 19, 2024 · 3 comments · May be fixed by #832
Assignees
Labels

Comments

@talsewell
Copy link

Reported by a student in the UNSW COMP4161 class:

When in a session that uses autocorres, the sledgehammer produces this nonsense outcome:

Sledgehammering...
vampire found a proof...
Derived "False" from these facts alone: demo1

That demo lemma was only ever written to try to explain what WPFix does. It looks like vampire (maybe without types) is somehow confused by it and think it is contradictory.

Anyway, it would be good to remove the names from these demo lemmas, or move them into a demo theory, or otherwise prevent them being seen by find_theorems, sledgehammer, etc.

@lsf37
Copy link
Member

lsf37 commented Dec 2, 2024

Hm, in the end this is a sledgehammer bug. The lemma isn't contradictory, so the translation is losing too much information.

But I do agree that we should remove the trigger. Are you sure that removing the name makes it invisible to sledgehammer? If not, maybe we can move it into an experiment context or otherwise discard it as a lemma if a separate Demo theory doesn't make sense. We do have the separate Demo theories for most setups, so that's probably the easiest way to go here, it's just a bit awkward in the Monads session itself.

@lsf37 lsf37 added the cleanup label Dec 2, 2024
@talsewell
Copy link
Author

Aha, I was sure there was something like experiment, thanks for reminding me of its name. I think any of these would fix the problem, and using experiment might be the simplest.

@lsf37 lsf37 linked a pull request Dec 2, 2024 that will close this issue
@lsf37
Copy link
Member

lsf37 commented Dec 2, 2024

You're right, experiment works fine for these: #832

@lsf37 lsf37 self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants