Adds multiline modifier support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanbrant
added a commit
that referenced
this pull request
Dec 6, 2014
Adds multiline modifier support
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KSS spec is vague on multiline support, but the ruby and node KSS implementations both support multiline modifier statements. I've opened see kneath/kss#105 to address multiline support in the spec. This adds multiline modifier support and required tests to pykss.
This changes the section parsing, adding state to track if a modifier block is being parsed still. If a modifier block has already begun, and a multiline statement match occurs, append to the last modifier description. If the modifier block ends, unmatched content still goes into the description.