Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(poststylus): update all PostStylus dependencies and devDependencies #28

Merged
merged 1 commit into from
Sep 26, 2020

Conversation

Kristinita
Copy link
Contributor

@Kristinita Kristinita commented Sep 25, 2020

1. Summary

I updated PostStylus dependencies and devDependencies to make it compatible with Autoprefixer 10.0.

2. MCVE

2.1. Data

You can see it in the KiraPostStylus2020 branch of my debugging/demo repository.

  • Gruntfile.coffee:

     module.exports = (grunt) ->
    
         grunt.loadNpmTasks 'grunt-contrib-stylus'
    
         postcss = ->
             require('poststylus') [
                 'autoprefixer'
             ]
    
         grunt.initConfig
    
             stylus:
                 options:
                     compress: false
                     linenos: false
                     use: [postcss]
                 themecompile:
                     files: [
                         src: 'KiraPostStylus.styl'
                         dest: 'KiraPostStylus.css'
                     ]
    
         return
  • KiraPostStylus.styl:

     .KiraExample
         display grid
         transition all .5s
         user-select none
         background linear-gradient(to bottom, white, black)

2.2. Before

  • .travis.yml:

     os: linux
    
     dist: focal
    
     git:
       depth: 1
    
     language: node_js
    
     node_js:
     - node
    
     install:
     - npm install -g grunt-cli
     - npm install
    
     script:
     - grunt stylus --verbose
  • Travis build failed:

    Warning: [object Object] is not a PostCSS plugin� Use --force to continue.

2.3. After

  • .travis.yml:

     os: linux
    
     dist: focal
    
     git:
       depth: 1
    
     language: node_js
    
     node_js:
     - node
    
     install:
     - npm install -g grunt-cli npm-check
     - npm install
     - npm-check node_modules/poststylus -y
    
     script:
     - grunt stylus --verbose
     - cat KiraPostStylus.css
  • Travis — dependencies and devDependencies updated:

[npm-check] Update complete!

[npm-check] multi-stage-sourcemap@0.3.1, postcss@8.0.9, chai@4.2.0, css-parse@2.0.0, eslint@7.9.0, mocha@8.1.3, stylus@0.54.8
  • Travis — successful Stylus to CSS build:

     Reading KiraPostStylus.styl…OK
    
     Writing KiraPostStylus.css…OK
    
     File KiraPostStylus.css created.
    
     >> 1 file created.
  • Travis — compiled CSS with prefixes:

     $ cat KiraPostStylus.css
    
     .KiraExample {
    
       display: grid;
    
       transition: all 0.5s;
    
       -webkit-user-select: none;
    
          -moz-user-select: none;
    
               user-select: none;
    
       background: linear-gradient(to bottom, #fff, #000);
    
     }

3. Environment

  1. Ubuntu 20.04.1 LTS
  2. Node.js 14.12.0
  3. grunt 1.3.0
  4. grunt-cli 1.3.2
  5. PostStylus 1.0.0
  6. Autoprefixer 10.0

Also, after my changes PostStylus works successfully in my real project.

Thanks.

@madeleineostoja
Copy link
Owner

LGTM, thanks!

@madeleineostoja madeleineostoja merged commit bbc93cd into madeleineostoja:master Sep 26, 2020
@Kristinita
Copy link
Contributor Author

Kristinita commented Sep 26, 2020

@seaneking , please don’t forget to publish the version with new changes to npm (in my practice, developers who have accepted a pull request often forget to do this).

Thanks.

@madeleineostoja
Copy link
Owner

Yes I've released a new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants