Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency resolution loops infinitely for erroneous dependencies #13

Open
davidgwking opened this issue Nov 21, 2014 · 0 comments
Open
Labels
Milestone

Comments

@davidgwking
Copy link
Collaborator

Within lib/flok.js.sortMigrationsUp, efforts are made to resolve dependencies. However, if a dependency is not satisfiable, a call to this function invokes an infinite while loop.

Consider a migration with this set of dependencies

module.exports.dependencies = ['1',, '2'];

Assume '1' and '2' are valid migration ids. unresolvedDeps is filtered down to [undefined], but undefined is never identified as a valid migration id, resulting in an infinite loop.

In this situation, I would expect that the function calls back with an error detailing what dependencies cannot be met.

@seangarner seangarner added the bug label Dec 3, 2014
@seangarner seangarner added this to the First release milestone Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants