Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing version_check #54

Open
matklad opened this issue Jun 17, 2023 · 0 comments
Open

Consider removing version_check #54

matklad opened this issue Jun 17, 2023 · 0 comments

Comments

@matklad
Copy link

matklad commented Jun 17, 2023

This crate currently uses version_check to support Rust versions older than 1.36.0. This is ancient history by Rust's standards, so perhaps it is worth it to remove build.rs and version_check altogether. The motivation being compilation-time performance --- one less deb and one less build.rs would shave off some milliseconds. Not a huge win, of course, but still a meaningful reduction, given crate's popularity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant