Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel Islands example throws "Looping" error if join ID property not specified #5

Open
twelch opened this issue Apr 14, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@twelch
Copy link
Contributor

twelch commented Apr 14, 2021

Expected Behavior

If you don't specify an originalIdProperty the union can still be performed, just slower.

Actual Behavior

However, for the Channel Islands example, it produces a looping error in makePolygons. I have not dug deeper to figure out why.

node scripts/debugExample.js examples/Channel-Islands.geojson    
segmentation: 7.774ms
index: 3.700ms
Error: Looping through the same path
    at _loop_2 (/Users/twelch/src/union-subdivided-polygons/dist/src/makePolygons.js:46:27)
    at _loop_1 (/Users/twelch/src/union-subdivided-polygons/dist/src/makePolygons.js:101:27)
    at makePolygons (/Users/twelch/src/union-subdivided-polygons/dist/src/makePolygons.js:162:9)
    at /Users/twelch/src/union-subdivided-polygons/scripts/debugExample.js:54:25
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Object.createConnection (/Users/twelch/src/union-subdivided-polygons/node_modules/slonik/dist/src/factories/createConnection.js:96:18)
polygonize: 9.998ms
union features total: 22.168ms

If you pass an originalIdProperty of _oid per usual, it works fine. Since that's the normal use, I expect the scenario of not passing a property just hasn't been tried in a while? Note that the property is now passed as an additional argumen tto debugExample.

node scripts/debugExample.js examples/Channel-Islands.geojson _oid
segmentation: 4.268ms
index: 0.388ms
polygonize: 0.845ms
union features total: 6.190ms
@twelch
Copy link
Contributor Author

twelch commented Feb 13, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant