Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow setting volumeServerAccess #176

Open
Gradlon opened this issue Aug 13, 2024 · 1 comment
Open

Feature: Allow setting volumeServerAccess #176

Gradlon opened this issue Aug 13, 2024 · 1 comment

Comments

@Gradlon
Copy link
Contributor

Gradlon commented Aug 13, 2024

In my setup, I would need to have the ability to set -volumeServerAccess=publicUrl for the volume plugin.
As far as I can see, this is not implemented in the driver code.

	// Values for override-able args
	//  Whitelist for merging with volContext
	argsMap := map[string]string{
		"collection":         seaweedFs.collection,
		"filer":              strings.Join(filers, ","),
		"filer.path":         seaweedFs.path,
		"cacheCapacityMB":    fmt.Sprint(seaweedFs.driver.CacheCapacityMB),
		"concurrentWriters":  fmt.Sprint(seaweedFs.driver.ConcurrentWriters),
		"map.uid":            seaweedFs.driver.UidMap,
		"map.gid":            seaweedFs.driver.GidMap,
		"disk":               "",
		"dataCenter":         "",
		"replication":        "",
		"ttl":                "",
		"chunkSizeLimitMB":   "",
		"volumeServerAccess": "",
		"readRetryTime":      "",
	}

It would be really helpful if that would be implemented.

@chrislusf
Copy link
Contributor

This is a white list. Any settings on this white list will be included when mounting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants