From 361651345cffe44ab28d3dd91f04450d54a4acf4 Mon Sep 17 00:00:00 2001 From: Sebastian Bergmann Date: Sun, 10 Mar 2024 13:39:09 +0100 Subject: [PATCH 1/3] Closes #5730 --- tests/unit/Framework/ExceptionWrapperTest.php | 21 ------------------- 1 file changed, 21 deletions(-) diff --git a/tests/unit/Framework/ExceptionWrapperTest.php b/tests/unit/Framework/ExceptionWrapperTest.php index 87e94524dd9..0f7b77bfccc 100644 --- a/tests/unit/Framework/ExceptionWrapperTest.php +++ b/tests/unit/Framework/ExceptionWrapperTest.php @@ -9,7 +9,6 @@ */ namespace PHPUnit\Framework; -use function print_r; use BadFunctionCallException; use Exception; @@ -39,24 +38,4 @@ public function testGetOriginalExceptionWithPrevious(): void $this->assertInstanceOf(BadFunctionCallException::class, $wrapper->getOriginalException()); } - - /** - * @runInSeparateProcess - */ - public function testNoOriginalExceptionInStacktrace(): void - { - $e = new BadFunctionCallException('custom class exception'); - $wrapper = new ExceptionWrapper($e); - - // Replace the only mention of "BadFunctionCallException" in wrapper - $wrapper->setClassName('MyException'); - - $data = print_r($wrapper, true); - - $this->assertStringNotContainsString( - 'BadFunctionCallException', - $data, - 'Assert there is s no other BadFunctionCallException mention in stacktrace', - ); - } } From 35efa7199aa96c635cdc18891fa58ef7c90b0a51 Mon Sep 17 00:00:00 2001 From: Sebastian Bergmann Date: Sun, 10 Mar 2024 17:57:03 +0100 Subject: [PATCH 2/3] Allow write operations --- .github/workflows/release.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index c2cf235c009..4fbd7f9b5a7 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -13,6 +13,9 @@ jobs: runs-on: ubuntu-latest + permissions: + contents: write + steps: - name: Checkout uses: actions/checkout@v4 From 3d44437fcdfd75ee18078237fe8e0b1815a1b98e Mon Sep 17 00:00:00 2001 From: Sebastian Bergmann Date: Sun, 10 Mar 2024 17:57:10 +0100 Subject: [PATCH 3/3] Fugbix typo --- .github/workflows/release.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 4fbd7f9b5a7..6c4d83ab41b 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -31,7 +31,7 @@ jobs: - name: Determine tag run: echo "RELEASE_TAG=${GITHUB_REF#refs/tags/}" >> $GITHUB_ENV - - name: Parse changelog + - name: Parse ChangeLog run: build/scripts/extract-release-notes.php ${{ env.RELEASE_TAG }} > release-notes.md - name: Create release