AssertCount on HHVM freezes #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the heads up. I should have a chance to look into this over the weekend. |
whatthejeff
added a commit
that referenced
this pull request
Aug 30, 2014
|
bb0c117 should prevent the infinite loop. The underlying cause was that PHPUnit tried to restore the iterator position after the assertion, but did not consider that some iterators are not rewindable. As to why there's a difference between PHP5 and HHVM, the |
whatthejeff
added a commit
that referenced
this pull request
Aug 30, 2014
AssertCount on HHVM freezes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue I discovered in fabpot/php-cs-fixer repository. When I'm using
$this->assertCount(1, $iterator)the scripts hangs for more than 10 minutes on HHVM... (I have not waited any longer than that)This PR on fabpot/php-cs-fixer is a workaround for the issue.
This PR does not solve the issue. The test I added is actually passing in HHVM... I want to get some understanding why the tests freezes in PHP-CS-Fixer on HHVM.
I tried, but I could not reproduce the issue on the Finder Component. I don't know how to move forward or where the bug is...