Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlBuilder InnerJoin implementation does not match the interface parameter order #477

Open
douwinga opened this issue Mar 9, 2023 · 0 comments
Open

SqlBuilder InnerJoin implementation does not match the interface parameter order #477

douwinga opened this issue Mar 9, 2023 · 0 comments

Comments

@douwinga
Copy link
Contributor

douwinga commented Mar 9, 2023 •
edited
Loading

I ran into an issue while using the SqlBuilder with an InnerJoin that messed me up for a bit.

The interface for InnerJoin has the order of parameters as string table, string onTable, string onColumn, string toTable, string toColumn, string schema, string alias = null, string toAlias = null.

The implementation of the interface for InnerJoin has the order of parameters as string table, string onTable, string onColumn, string toTable, string schema, string toColumn, string alias = null, string toAlias = null.

The shema and toColumn parameters are swapped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@douwinga