Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Microsoft.Data.Sqlite to v8.0.0 #510

Closed
Piedone opened this issue Nov 14, 2023 · 4 comments · Fixed by #513
Closed

Upgrade Microsoft.Data.Sqlite to v8.0.0 #510

Piedone opened this issue Nov 14, 2023 · 4 comments · Fixed by #513

Comments

@Piedone
Copy link
Contributor

Piedone commented Nov 14, 2023

The v.8.0.0 of Microsoft.Data.Sqlite is out. That depends on >=2.1.6 of SQLitePCLRaw.bundle_e_sqlite3. This in turn is notable because it fixes an issue where you get the below build warnings when building a project using it under the .NET 8 SDK (see ericsink/SQLitePCL.raw#543).

Found version-specific or distribution-specific runtime identifier(s): alpine-arm, alpine-arm64, alpine-x64. Affected libraries: SQLitePCLRaw.lib.e_sqlite3. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details.

@MikeAlhayek
Copy link
Collaborator

@Piedone if you are planning to submit a PR, please target release/4.0 instead of main.

@sebastienros
Copy link
Owner

but this could also be released today on 3.x and merged into release/4.0, if it's blocking it doesn't have to wait and it is not a breaking change

@MikeAlhayek
Copy link
Collaborator

@sebastienros yes sure if you want to depend on .net 8

@sebastienros
Copy link
Owner

@MikeAlhayek Sqlite 8.0 targets .NET Standard 2.0 (check on nuget, I did too). The issue might appear with the SDK 8.0, but the package doesn't target net8.0 "only". It targets all TFMs. However what Zoltan says is that if the application targets net8.0 (or if they use the latest sdk, I am not sure) there is a warning.

If we bump to sqlite 8.0, we can still target net6.0 specifically (and version above as a result) without breaking anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants