Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcase byDay even when used with bySetPos #205

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

rubys
Copy link
Contributor

@rubys rubys commented Aug 3, 2020

Standalone test case:

const icaljs = require('ical.js');
const icalgen = require('ical-generator');

let event = {
  uid: 'unique',
  summary: 'repeat every third sunday',
  start: '2020-02-20T12:00:00Z',
  repeating: {
    freq: 'MONTHLY', // required
    count: 5,
    byDay: 'su', // repeat only sunday
    bySetPos: 3, // repeat every 3rd sunday
  }
}

let ical = icalgen({});
ical.createEvent(event);
console.log(ical.toString());
icaljs.parse(ical.toString());

@rubys rubys force-pushed the upcase_byDay_with_bySetPos branch from 410ebc6 to b883fae Compare August 4, 2020 13:10
@sebbo2002 sebbo2002 self-assigned this Aug 6, 2020
@sebbo2002 sebbo2002 added the bug label Aug 6, 2020
@sebbo2002 sebbo2002 merged commit 5440fbc into sebbo2002:develop Aug 6, 2020
@sebbo2002
Copy link
Owner

Just published version 1.12.1, thanks for your PR ❤️

sebbo2002 pushed a commit that referenced this pull request Feb 27, 2021
# [1.3.0-develop.1](v1.2.1...v1.3.0-develop.1) (2021-02-27)

### Bug Fixes

* **package.json:** add temporary version ([0bc117e](0bc117e))
* allow X-attrs to be specified in constructor ([#185](#185)) ([58c1ae5](58c1ae5))
* capitalize byDay even when bySetPos is used ([#205](#205)) ([5440fbc](5440fbc))
* **Typings:** Fix OPT-PARTICIPANT ([b777f9e](b777f9e)), closes [#192](#192)
* Fix scale type for CalendarData ([#191](#191)) ([d5421e8](d5421e8))
* Make x key optional in types ([#211](#211)) ([e3c21e2](e3c21e2))
* Type fixes and updates ([#217](#217)) ([d8abe4d](d8abe4d))

### Features

* **Events:** Add appleLocation method ([#170](#170)) ([0956ba2](0956ba2))
* Add missing string input options to interface ([#199](#199)) ([a963178](a963178))
* Add Transparency Method ([bd2901d](bd2901d))
* Increase id entropy - Fixes [#200](#200) ([#202](#202)) ([6711b0a](6711b0a))
* make domain optional ([#209](#209)) ([e3362c9](e3362c9))
* Updated the entire codebase to Typescript ([d013dc0](d013dc0))
* **Events:** use provided timezone when constructing repeating.exclude ([#210](#210)) ([bd84230](bd84230))
@sebbo2002
Copy link
Owner

🎉 This PR is included in version 1.3.0-develop.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants