Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Finish and add length of packet in vtp.py #1494

Closed
nikhilh-20 opened this issue Jun 25, 2018 · 2 comments
Closed

[question] Finish and add length of packet in vtp.py #1494

nikhilh-20 opened this issue Jun 25, 2018 · 2 comments

Comments

@nikhilh-20
Copy link

From #399 ,

Considering the four fixed options in the VTP header: Version, Message Type, Management Domain Length and Management Domain Name (each 1 byte), can the ByteField length be set to 4? Would this be the solution?

#nikhilh@ubuntu$ uname -a
Linux ubuntu 4.13.0-45-generic #50~16.04.1-Ubuntu SMP Wed May 30 11:18:27 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

I'm using scapy version 2.4.0.dev303

@nikhilh-20 nikhilh-20 changed the title Finish and add length of packet in vtp.py [question] Finish and add length of packet in vtp.py Jun 26, 2018
@gpotter2
Copy link
Member

No. The issue is expecting you to add a post_build function that would add edit the packet after being built.

Many other packets use the same trick, for instance https://github.com/secdev/scapy/blob/master/scapy/layers/dns.py#L327 (be careful, the fact that it checks TCP first is specific to DNS, do not copy/paste it as so)

@guedou
Copy link
Member

guedou commented May 31, 2019

Moved to #399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants